rmcguire/go-app
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

improve grpc lifecycle

Browse Source
This commit is contained in:
Ryan McGuire
2025-03-07 17:04:46 -05:00
parent c5da5f7887
commit e178956eef
3 changed files with 30 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
pkg/app/app.go
View File

@ -17,8 +17,6 @@ func (a *App) Done() <-chan any {
func (a *App) MustRun() {
if a.cfg != nil {
panic(errors.New("already ran app trying to run"))
} else if !a.cfg.HTTP.Enabled && !a.cfg.GRPC.Enabled {
panic(errors.New("neither http nor grpc enabled, nothing to do"))
}
// Set up app
@ -28,17 +26,23 @@ func (a *App) MustRun() {
a.appDone = make(chan any)
a.HTTP.HTTPDone = make(chan any)
if !a.cfg.HTTPEnabled() && !a.cfg.GRPCEnabled() {
panic(errors.New("neither http nor grpc enabled, nothing to do"))
}
if len(a.HTTP.Funcs) < 1 {
a.l.Warn().Msg("no http funcs provided, only serving health and metrics")
}
// Start OTEL
// Registers a NO-OP provider if not enabled
a.initOTEL()
ctx, initSpan := a.tracer.Start(a.AppContext, "init")
defer initSpan.End()
// Start HTTP (does not block)
if a.cfg.HTTP.Enabled {
if a.cfg.HTTPEnabled() {
if err := a.initHTTP(ctx); err != nil {
initSpan.RecordError(err)
initSpan.SetStatus(codes.Error, err.Error())
@ -48,7 +52,7 @@ func (a *App) MustRun() {
}
// Start GRPC (does not block)
if a.cfg.GRPC.Enabled {
if a.cfg.GRPCEnabled() {
if err := a.initGRPC(ctx); err != nil {
initSpan.RecordError(err)
initSpan.SetStatus(codes.Error, err.Error())