move recorder to interface

pkg/ambient/ambient.go

@@ -30,13 +30,13 @@ type AmbientWeather struct {
 	// when either "AmbientWeather" or "Wunderground" are selected
 	// in the "Custom" section of the AWNet app, or the web UI
 	// of an Ambient WeatherHub
-	Config       *config.AmbientLocalExporterConfig
-	awnProvider  provider.AmbientProvider
-	wuProvider   provider.AmbientProvider
-	weatherState *recorder.WeatherRecorder
-	appCtx       context.Context
-	metrics      *weather.WeatherMetrics
-	l            *zerolog.Logger
+	Config          *config.AmbientLocalExporterConfig
+	awnProvider     provider.AmbientProvider
+	wuProvider      provider.AmbientProvider
+	weatherRecorder *recorder.WeatherRecorder
+	appCtx          context.Context
+	metrics         *weather.WeatherMetrics
+	l               *zerolog.Logger
 	*sync.RWMutex
 }
 
@@ -70,7 +70,8 @@ func (aw *AmbientWeather) Init() *AmbientWeather {
 	}
 	span.SetAttributes(attribute.Int("updatesToKeep", updatesToKeep))
 
-	aw.weatherState = recorder.NewWeatherRecorder(&recorder.Opts{
+	// TODO: Support other recorders (don't rely on default)
+	aw.weatherRecorder = recorder.NewWeatherRecorder(&recorder.Opts{
 		Ctx:      aw.appCtx,
 		KeepLast: updatesToKeep,
 	})
@@ -142,7 +143,7 @@ func (aw *AmbientWeather) handleProviderRequest(
 	}
 
 	// Record state
-	aw.weatherState.Set(ctx, update)
+	aw.weatherRecorder.Set(ctx, update)
 
 	// Update metrics
 	aw.metricsUpdate(ctx, p, update)
@@ -277,9 +278,9 @@ func (aw *AmbientWeather) enrichStation(update *weather.WeatherUpdate) {
 	}
 }
 
-func (aw *AmbientWeather) GetState() *recorder.WeatherRecorder {
+func (aw *AmbientWeather) GetRecorder() *recorder.WeatherRecorder {
 	aw.RLock()
 	defer aw.RUnlock()
 
-	return aw.weatherState
+	return aw.weatherRecorder
 }