From 268bc7d8a24ba927d2e0577876b3f0c820ac530e Mon Sep 17 00:00:00 2001 From: Ryan D McGuire Date: Thu, 3 Apr 2025 10:44:43 -0400 Subject: [PATCH] code tweaks --- pkg/weather/metrics_record.go | 15 +++------------ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/pkg/weather/metrics_record.go b/pkg/weather/metrics_record.go index bd08d62..4f31443 100644 --- a/pkg/weather/metrics_record.go +++ b/pkg/weather/metrics_record.go @@ -3,6 +3,7 @@ package weather import ( "context" "errors" + "slices" "github.com/rs/zerolog" "go.opentelemetry.io/otel/attribute" @@ -64,20 +65,10 @@ func (r *MetricRecorder) Record(opts *RecordOpts) { func (o *RecordOpts) keep() bool { // If keep fields are given, only check keep fields if len(o.Station.KeepMetrics) > 0 { - for _, f := range o.Station.KeepMetrics { - if f == o.Field { - return true - } - } - return false + return slices.Contains(o.Station.KeepMetrics, o.Field) } - for _, f := range o.Station.DropMetrics { - if f == o.Field { - return false - } - } - return true + return !slices.Contains(o.Station.DropMetrics, o.Field) } func (r *MetricRecorder) recordInt(